Skip to content

Rework on code review process

tusooa requested to merge tusooa/T1-rework-code-review-process into servant

Summary | 概述:

  1. We are no longer using the changelog directory, and will be using the title and description of the MR/Differential Revision as the changelog entry instead.
  2. For an MR, this means all commits will be squashed.
  3. The original check-changelog job is removed, and we will no longer have duplicated pipelines for branches and MRs.
  4. For a differential revision, use arc land to land the changes.
  5. When running arc diff, it will push to a staging area, which is a GitLab repo, and the pipeline will be triggered from Phorge. The link to the pipeline will be reported to the build target.

https://iron.lily-is.land/T1

Type | 类型: skip

Test Plan | 测试计划:

  1. For MR:

    1. Create an MR based on this.
    2. Verify that check-changelog won't run.
    3. Verify that report-start and report-final won't run.
    4. Verify that all other jobs are still run.
    5. Verify that you can squash the commits when merging, and the commit message contains the title and full description of the MR. DO NOT merge yet.
  2. For Differential Revision:

    1. Create a Differential Revision based on this (very important) (like arc diff HEAD^). It will ask you to push to staging area.
    2. Verify that report-start and report-final are both run for phabricator/diff/xxx.
    3. Verify that after report-start, you can see in Harbormaster that the build is in progress and the link.
    4. Verify that after report-final, you can see in Harbormaster that the build is finished.
    5. Update the diff to make the build fail, and you should see in Harbormaster that the build is failed.
    6. Verify that the pipelines are NOT run for phabricator/base/xxx tags.
    7. Verify that if you do not include a Type: specification in the Revision summary, it will add a comment asking you to do so.
Edited by tusooa

Merge request reports