Rework on code review process
Summary | 概述:
- We are no longer using the changelog directory, and will be using the title and description of the MR/Differential Revision as the changelog entry instead.
- For an MR, this means all commits will be squashed.
- The original check-changelog job is removed, and we will no longer have duplicated pipelines for branches and MRs.
- For a differential revision, use
arc land
to land the changes. - When running
arc diff
, it will push to a staging area, which is a GitLab repo, and the pipeline will be triggered from Phorge. The link to the pipeline will be reported to the build target.
Type | 类型: skip
Test Plan | 测试计划:
-
For MR:
- Create an MR based on this.
- Verify that check-changelog won't run.
- Verify that report-start and report-final won't run.
- Verify that all other jobs are still run.
- Verify that you can squash the commits when merging, and the commit message contains the title and full description of the MR. DO NOT merge yet.
-
For Differential Revision:
- Create a Differential Revision based on this (very important) (like
arc diff HEAD^
). It will ask you to push to staging area. - Verify that report-start and report-final are both run for
phabricator/diff/xxx
. - Verify that after report-start, you can see in Harbormaster that the build is in progress and the link.
- Verify that after report-final, you can see in Harbormaster that the build is finished.
- Update the diff to make the build fail, and you should see in Harbormaster that the build is failed.
- Verify that the pipelines are NOT run for
phabricator/base/xxx
tags. - Verify that if you do not include a
Type:
specification in the Revision summary, it will add a comment asking you to do so.
- Create a Differential Revision based on this (very important) (like
Edited by tusooa